fix: should not set "Content-Encoding" for a direct request of a compressed file #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content-Encoding
should be used only when sirv is serving pre-compressed files (e.g. request: test.csv --> response: test.csv.gz), but it should be avoided when users are requesting a compressed file directly (e.g. test.csv.gz).Citing from https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding
The summary of changes in this PR is:
extns: string
withextns: { ext: string, encoded: boolean }[]
,viaLocal
orviaCache
, it also returns{ name: string, encoded: boolean }
Content-Type
andContent-Encoding
handling fromtoHeaders
tosend
since it now requiresname
andencoded
to decide these two headers.Diff looks a little involved, but I hope this is clear and correct. I would appreciate a review. Thanks!